finalize 2.9.0 #1180
Merged
finalize 2.9.0 #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hitenkoku
reviewed
Sep 21, 2023
There was a problem hiding this comment.
@YamatoSecurity Thanks for your pull request.
I commented because I am a little concerned about some of the descriptions in CHANGELOG.
Could you please confirm this?
Co-authored-by: DustInDark <[email protected]>
Co-authored-by: DustInDark <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1180 +/- ##
==========================================
- Coverage 83.82% 83.74% -0.08%
==========================================
Files 26 26
Lines 23388 23492 +104
==========================================
+ Hits 19604 19673 +69
- Misses 3784 3819 +35
☔ View full report in Codecov by Sentry. |
|
@hitenkoku Since it is a simple change and I want to release soon today I added the code for #1182 |
|
@YamatoSecurity thanks for your add. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalized for 2.9.0.